Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusBar tintColor problems #111

Closed
txaiwieser opened this issue Jan 19, 2017 · 35 comments
Closed

StatusBar tintColor problems #111

txaiwieser opened this issue Jan 19, 2017 · 35 comments
Assignees

Comments

@txaiwieser
Copy link

txaiwieser commented Jan 19, 2017

We just implemented the instabug framework in our App. But we are experiencing a lot of bugs related to the StatusBar color, we made a lot of tests and its definitely Instabug's fault.

We use a ViewController based StatusBar configuration, and most view controllers have a white StatusBar. And even without accessing the instabug button, the status bar turn black in some app VCS.

One small case is when we present in a VC (white statusbar) a SFViewController (black statusbar) it changes to black (as it should) and when we dismiss the SFViewController it should change back to white. Bug with Instabug enabled it doesnt change back in some times. When it does changes it appears to be fake and without animations.

I love instabug, but with this bug its very unlikely we can push to our betas :/

Thanks! 👍

@Kmohamed
Copy link
Contributor

@txaiwieser
Let me check and get back to you.

@Kmohamed
Copy link
Contributor

Kmohamed commented Jan 19, 2017

@txaiwieser
I succeeded on reproduce the bug and we are working on it.
I would like to ask If you are using floating button or not.

@txaiwieser
Copy link
Author

@Kmohamed Yes, we are using the floating button. But this issue happens even when the button wasn't pressed.

@Kmohamed
Copy link
Contributor

@txaiwieser
Sorry for inconvenience.
Here is a custom build with a fix. and we are going to release the fix soon.
Instabug.framework.zip

@txaiwieser
Copy link
Author

Thanks you for the quick fix! Gladly appreciated!

😄👍

@Kmohamed
Copy link
Contributor

Anytime :)

@txaiwieser
Copy link
Author

This bug has returned!
Now it happens every time I "peak and pop" in a cell, for example

@txaiwieser txaiwieser reopened this Mar 22, 2017
@Kmohamed
Copy link
Contributor

@txaiwieser Could you send me screenshot with the bug ?

@txaiwieser
Copy link
Author

The status bar just changes to black after you "peak and pop" in any cell that supports it. (the app I work has white status bar)

@Kmohamed
Copy link
Contributor

I will check it and get back to you as soon as possible

@Kmohamed
Copy link
Contributor

@txaiwieser I implement Peek and pop in a project using Instabug SDK but it does not change status bar color.
Could you confirm the SDK version runs on that device is greater than 7.0

@txaiwieser
Copy link
Author

Yes, I using the latest version through Carthage. And the App uses UIViewControllerBasedStatusBarAppearance.

@Kmohamed
Copy link
Contributor

My demo also uses UIViewControllerBasedStatusBarAppearance
Could you send to me a sample app with the bug ?

@Kmohamed
Copy link
Contributor

@txaiwieser I would like to ask If you have enough time to send to us a sample project with peek and pop bug.

@txaiwieser
Copy link
Author

I did the sample project and it turns out the problem happens only when linking with Carthage (with the new method described in the readme).

binary "https://raw.githubusercontent.com/Instabug/Instabug-iOS/master/Carthage.json"

It's not linked with the latest version 7.1 (with has this problem solved)

Sorry for the trouble, can we have this son pointing to the latest version?

Thanks!

@HeshamMegid
Copy link
Contributor

@txaiwieser that's weird. Both CocoaPods and Carthage and currently updated to the latest version. Would you please confirm that the build number of the SDK you get is 7311?

@txaiwieser
Copy link
Author

It seems to be solved in the last version.

@txaiwieser
Copy link
Author

This is still happening on iOS 9.3

Why do you have to swizzle everything? :/

@txaiwieser txaiwieser reopened this Sep 15, 2017
@Kmohamed
Copy link
Contributor

Kmohamed commented Sep 15, 2017

@txaiwieser could please clarify which problem is still happening on iOS 9.3 ?

@txaiwieser
Copy link
Author

  • New Xcode project
  • Change ViewController status bar style
 override var preferredStatusBarStyle: UIStatusBarStyle {
    return .lightContent
}
  • Add Instabug with dark style

Status bar does not change to light on iOS 9.3

@Kmohamed
Copy link
Contributor

I just tried your steps but did not succeed to reproduce the issue. The status bar style is light before invoking Instabug and after dismissing Instabug.
are you sure it is not and old version of sdk that has the issue ?

@txaiwieser
Copy link
Author

I'm using 7.3.7.
Did you have related fixes on yesterday's version?

@Kmohamed
Copy link
Contributor

No, but I can send you my sample project to see if I making something wrong or you can send me a sample project if you have.

@txaiwieser
Copy link
Author

Sure, I added one line to AppDelegate from the Xcode template. And setting the VC to use .lightContent
Testing.zip

@Kmohamed
Copy link
Contributor

@txaiwieser Thanks a lot I will look in it and get back to you soon.

@Kmohamed
Copy link
Contributor

@txaiwieser I would like to share with you something very interesting that If you create the same project from Xcode 8 and run it on iOS 9.3 it will work fine.
could you confirm this point please ?

@Kmohamed Kmohamed self-assigned this Sep 16, 2017
@Kmohamed
Copy link
Contributor

@txaiwieser also could you confirm that it's not simulator bug "Xcode 9 GM - iOS 9.3 simulator" ?

@Kmohamed
Copy link
Contributor

@txaiwieser could you confirm please this strange behaviour ?

@txaiwieser
Copy link
Author

@Kmohamed Unfortunately I couldn’t get an iOS 9 device yet, but the problem persist on the simulator

@Kmohamed
Copy link
Contributor

Kmohamed commented Oct 14, 2017

@txaiwieser I am very sorry for being late. But it takes a lot of time to find a work around on iOS9
could you give this custom build a try and tell if it works fine.
pod ‘Instabug’, :git => ’https://github.com/Instabug/Instabug-iOS.git', :branch => ‘fix/StatusBarColor_iOS9’

@Kmohamed
Copy link
Contributor

@txaiwieser I will close the issue now but also feel free to open it again if it shows up again.

@txaiwieser
Copy link
Author

Unfortunately this is not perfect yet.

• At first it seemed fixed, but after entering a SafariViewController or even on Instabug (via button), (any vc that changes the statusBar to black). After I go back to the app the bar stays black and doesn't change to white again.

@txaiwieser
Copy link
Author

Up

@Kmohamed
Copy link
Contributor

I am very sorry for being late we are still working on it and definitely will update you once it’s fixed.

@Kmohamed
Copy link
Contributor

Kmohamed commented Nov 1, 2017

Hello @txaiwieser Finally we found a fix for the issue 🎉🎉🎉🎉🎉
We are very sorry for being later you can not imagine how it takes to fix this issue, so kindly give it a try 🙂
pod ‘Instabug’, :git => ’https://github.com/Instabug/Instabug-iOS.git', :branch => ‘custom/fix-statusbar-style-iOS9’

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants