Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublimetext #623

Closed
BClare19 opened this issue Jul 13, 2022 · 5 comments
Closed

Sublimetext #623

BClare19 opened this issue Jul 13, 2022 · 5 comments
Labels
application adds or improves an application label

Comments

@BClare19
Copy link

Sublimetext no longer downloading and installing

Seems they don't link directly to the ZIP anymore. They use a thanks page which then directs the browser to the specific platform's URL. After discussing on slack

https://www.sublimetext.com/download_thanks?target=mac

Thanks

@pythoninthegrass
Copy link
Contributor

This is working for me:

curl -fs https://www.sublimetext.com/download_thanks?target=mac | grep -io -m 1 "https://download.*_mac.zip" | head -1

the | head -1 bit is technically optional, but in the event there are two identical URLs on one line, the -m 1 would return both (source).

Can open a PR in a few minutes.

@pythoninthegrass
Copy link
Contributor

Working through local testing with assemble.sh. Will have a PR by EOD.

@pythoninthegrass
Copy link
Contributor

Didn't have time to fully debug the error output while downloading:

2022-07-14 19:34:19 : REQ   : sublimetext : ################## Start Installomator v. 9.2, date 2022-05-16
2022-07-14 19:34:19 : INFO  : sublimetext : ################## Version: 9.2
2022-07-14 19:34:19 : INFO  : sublimetext : ################## Date: 2022-05-16
2022-07-14 19:34:19 : INFO  : sublimetext : ################## sublimetext
2022-07-14 19:34:19 : INFO  : sublimetext : BLOCKING_PROCESS_ACTION=prompt_user
2022-07-14 19:34:19 : INFO  : sublimetext : NOTIFY=success
2022-07-14 19:34:19 : INFO  : sublimetext : LOGGING=INFO
2022-07-14 19:34:20 : INFO  : sublimetext : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2022-07-14 19:34:20 : INFO  : sublimetext : Label type: zip
2022-07-14 19:34:20 : INFO  : sublimetext : archiveName: Sublime Text.zip
2022-07-14 19:34:20 : INFO  : sublimetext : no blocking processes defined, using Sublime Text as default
2022-07-14 19:34:20 : INFO  : sublimetext : name: Sublime Text, appName: Sublime Text.app
2022-07-14 19:34:20 : WARN  : sublimetext : No previous app found
2022-07-14 19:34:20 : WARN  : sublimetext : could not find Sublime Text.app
2022-07-14 19:34:20 : INFO  : sublimetext : appversion:
2022-07-14 19:34:20 : INFO  : sublimetext : Latest version of Sublime Text is Build 4126
2022-07-14 19:34:20 : REQ   : sublimetext : Downloading  to Sublime Text.zip
2022-07-14 19:34:20 : ERROR : sublimetext : error downloading
2022-07-14 19:34:20 : ERROR : sublimetext : File list:
2022-07-14 19:34:20 : ERROR : sublimetext : File type: Sublime Text.zip: cannot open `Sublime Text.zip' (No such file or directory)
2022-07-14 19:34:20 : INFO  : sublimetext : App not closed, so no reopen.
2022-07-14 19:34:20 : ERROR : sublimetext : ERROR: Error downloading  error:
* Closing connection -1
curl: (3) URL using bad/illegal format or missing URL

2022-07-14 19:34:20 : REQ   : sublimetext : ################## End Installomator, exit code 2

Fragment:

sublimetext)
    # credit: Søren Theilgaard (@theilgaard); Lance Stephens (@pythoninthegrass)
    name="Sublime Text"
    type="zip"
    downloadURL=$(curl -fs https://www.sublimetext.com/download_thanks?target=mac | grep -io -m 1 "https://download.*_mac.zip" | head -1)
    appNewVersion=$(curl -fs https://www.sublimetext.com/download | grep -i -A 4 "id.*changelog" | grep -io "Build [0-9]*")
    expectedTeamID="Z6D26JE4Y4"
    ;;

Suspect it breaks downstream. Will circle back tomorrow.

@scriptingosx scriptingosx added the application adds or improves an application label label Jul 18, 2022
@scriptingosx
Copy link
Collaborator

see also #578

@scriptingosx
Copy link
Collaborator

closed with #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application adds or improves an application label
Projects
None yet
Development

No branches or pull requests

3 participants