Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Workspace ONE changes to branch #648

Closed
mwmatter opened this issue Aug 15, 2022 · 2 comments · Fixed by #653
Closed

Merge Workspace ONE changes to branch #648

mwmatter opened this issue Aug 15, 2022 · 2 comments · Fixed by #653
Labels

Comments

@mwmatter
Copy link
Contributor

In the current beta release: https://github.com/Installomator/Installomator/releases/tag/v10beta1 one of the changes called out is:

"added WorkspaceOne option for LOGO (#517)"

After reviewing the main Installomator script I do not see the changes in the actual file. I do see the merge was committed here: 84d4184 but following that through I do not see the changes in the actual script.

Thanks!

@scriptingosx
Copy link
Collaborator

so the changes you made were made to the Installomator.sh in the root of the repo. (I missed this sorry) That file gets assembled from the fragments in the fragments folder. See description of the process here.

Can you re-create the changes in the proper fragments files, in a new PR, please?

@mwmatter
Copy link
Contributor Author

My mistake! I'm still new at all this. I created a new PR hopefully the correct way now: #653. Let me know if you need anything else.

@scriptingosx scriptingosx linked a pull request Aug 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants