Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ArmSimulationBuilder and move general functionality to a base class #2168

Closed
ZDu-IDM opened this issue Jan 24, 2024 · 1 comment
Closed

Refactor ArmSimulationBuilder and move general functionality to a base class #2168

ZDu-IDM opened this issue Jan 24, 2024 · 1 comment
Assignees
@ZDu-IDM
Labels
Core

Comments

@ZDu-IDM
Copy link
Collaborator

ZDu-IDM commented Jan 24, 2024 •
edited

Current ArmSimulationBuilder inherits from SimulationBuilder, and they share some functionality but handle some cases differently.

Suggest to refactor the ArmSimulationBuilder (as well as SimulationBuilder) by moving some basic functionality to some base class.

For example,

  • move basic functions from SimulationBuildder to SweepArm
  • SimulationBuilder will inherits from SweepArm
  • ArmSimulationBuilder will inherits from SimulationBuilder
@ZDu-IDM ZDu-IDM added the Core label Jan 24, 2024
@ZDu-IDM ZDu-IDM self-assigned this Jan 24, 2024
@ZDu-IDM ZDu-IDM changed the title Refactor ArmSimulationBuilder and more general functionality to a base class Refactor ArmSimulationBuilder and move general functionality to a base class Jan 24, 2024
@shchen-idmod
Copy link
Collaborator

Fixed in 1.7.10 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZDu-IDM ZDu-IDM

Labels
Core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZDu-IDM @shchen-idmod