Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and move unittests in core and cli packages not depending on idmtools_models package #2174

Closed
shchen-idmod opened this issue Jan 30, 2024 · 1 comment

Comments

@shchen-idmod
Copy link
Collaborator

There are many idmtools_core and idmtools_cli tests are depending on idmtools_models package.
But idmtools_models package also depends on core package.
It is better we do not do this type of circular dependency even for unittests

Most of tests in core which depending on idmtools_models package can be replaced with idmtools_test package. If not we can move these tests to idmtools_models tests

@shchen-idmod
Copy link
Collaborator Author

Fixed in 1.7.10 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant