Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Simulation builders (fixed several issues) #2184

Merged
merged 51 commits into from Feb 22, 2024
Merged

Improved Simulation builders (fixed several issues) #2184

merged 51 commits into from Feb 22, 2024

Conversation

ZDu-IDM
Copy link
Collaborator

@ZDu-IDM ZDu-IDM commented Feb 1, 2024 •
edited

This PR addressed
#2065
#2165
#2166
#2167
#2183
#2194
#2195

ZDu-IDM and others added 23 commits February 1, 2024 12:19
@ZDu-IDM
fix len issue and as well as single value case
2af66ba
@ZDu-IDM
simplified the code
a07434a
@ZDu-IDM
fix a typo
38cac89
@ZDu-IDM
re-name utility function
25e9c35
@ZDu-IDM
re-factoring csv builder and yaml builder
42d1559
@ZDu-IDM
remove type from yaml builder
fa73e30
@ZDu-IDM
fix typo
ff0668c
@ZDu-IDM
code cleanup
f577eb0
@ZDu-IDM
add sweep_type back
06e8dc6
@ZDu-IDM
remove sweep_type
f0239c3
@ZDu-IDM
remove space (test)
69990e9
@ZDu-IDM
take care of the dict case
ab7b754
@shchen-idmod
add and update builder tests
f25a7fd
@shchen-idmod
simplified tests
f57515a
@shchen-idmod
Add few more cases for armbuilder and simulation_bulider
6eda1b5
@shchen-idmod
remove unused comments
e5d0cb1
@ZDu-IDM
implement InstituteforDiseaseModeling#2192
fda39f0
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
ba468e2 
…ools into fix_arm_builder
@shchen-idmod
Adding more cases for simulation_builder
1dee6bf
@shchen-idmod
Update subtest and title of the test in test_simulation_builder.py
5c83346
@ZDu-IDM
refactor builders
706daee
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
a553ee1 
…ools into fix_arm_builder
@ZDu-IDM
simplified, fixed issues aand updated error messages
10b589e
@ZDu-IDM ZDu-IDM self-assigned this Feb 14, 2024
ZDu-IDM and others added 23 commits February 14, 2024 16:17
@ZDu-IDM
remove dataframe checking
d78b01f
@ZDu-IDM
simplified and updated docstring
f90f46d
@ZDu-IDM
Updated docstring
b0d6ab9
@shchen-idmod
Merge branch 'dev' of https://github.com/InstituteforDiseaseModeling/…
ed2ad3e 
…idmtools into fix_arm_builder
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
e16c9c0 
…ools into fix_arm_builder
@ZDu-IDM
simplify a bit
3eac5f6
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
95300ba 
…ools into fix_arm_builder
@ZDu-IDM
handle special case
308d2c4
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
9faf1af 
…ools into fix_arm_builder
@shchen-idmod
rewrite all tests for test_simulation_builder.py
aee7d1c
@shchen-idmod
Update test_multiple_builders.py with new code
1ac57df
@ZDu-IDM
handle special DataFrame case
6577a3a
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
719d942 
…ools into fix_arm_builder
@shchen-idmod
Fix failed case in test_arm_builder.py
4bd0e8a
@shchen-idmod
Add pandas testcase in test_simulation_builder.py
3da41f8
@shchen-idmod
update examples and change multiple_parameter_sweeping to use add_swe…
0ebd511 
…ep_definition
@ZDu-IDM
add docstring for functions
2b18796
@shchen-idmod
Merge branch 'fix_arm_builder' of https://github.com/ZDu-IDM/zdu_idmt…
d75b740 
…ools into fix_arm_builder
@ZDu-IDM
add docstring for functions
4ca4455
@shchen-idmod
Fix docstring error
0881b8e
@shchen-idmod
Fix docstring error
87a275c
@shchen-idmod
Added more error handling cases and add few more other cases
22849a3
@ZDu-IDM
Merge pull request #7 from shchen-idmod/fix_arm_builder
bce46d6 
add and update builder tests
shchen-idmod
shchen-idmod approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@shchen-idmod shchen-idmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@shchen-idmod shchen-idmod merged commit 3673d23 into InstituteforDiseaseModeling:dev Feb 22, 2024
4 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shchen-idmod shchen-idmod shchen-idmod approved these changes

Assignees

@ZDu-IDM ZDu-IDM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZDu-IDM @shchen-idmod