Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Simulation Builders to remove duplicated code #2196

Closed
ZDu-IDM opened this issue Feb 16, 2024 · 1 comment
Closed

Refactor Simulation Builders to remove duplicated code #2196

ZDu-IDM opened this issue Feb 16, 2024 · 1 comment
Assignees
@ZDu-IDM
Labels
Core

Comments

@ZDu-IDM
Copy link
Collaborator

ZDu-IDM commented Feb 16, 2024 •
edited

Currently the main objects SweepArm, SimulationBuilder and ArmSimulationBuilder have several parts of duplicated coding due to classes not properly inheriting structure.

It is better to refactor the main classes and make proper class inheritance to reduce/remove the duplicated code.
@issuelabeler issuelabeler bot added the duplicate This issue or pull request already exists label Feb 16, 2024
@ZDu-IDM ZDu-IDM added Core and removed duplicate This issue or pull request already exists labels Feb 16, 2024
@ZDu-IDM ZDu-IDM self-assigned this Feb 16, 2024
@ZDu-IDM ZDu-IDM mentioned this issue Mar 7, 2024
Merged
@shchen-idmod
Copy link
Collaborator

Fixed in 1.7.10 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZDu-IDM ZDu-IDM

Labels
Core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZDu-IDM @shchen-idmod