Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download asset and use asset id in generate singularity builder instead of assetcollection #2210

Merged
merged 15 commits into from Mar 20, 2024
Merged

Add download asset and use asset id in generate singularity builder instead of assetcollection #2210

merged 15 commits into from Mar 20, 2024

Conversation

shchen-idmod
Copy link
Collaborator

#2032 -- Assetization workflow for generating SIF image should track using Asset ID instead of AC ID
#2011 -- Feature request: add download method to download asset to local file

@shchen-idmod
Merge branch 'dev' of https://github.com/InstituteforDiseaseModeling/…
2033861 
…idmtools into fix_wait
@shchen-idmod
add download asset method and download asset_id to file for singulari…
d63a6f9 
…ty builder
@shchen-idmod
Merge branch 'dev' of https://github.com/InstituteforDiseaseModeling/…
8b06cf5 
…idmtools into asset_id
@shchen-idmod
remove test_download_asset test in test_assets.py
4a57651
@shchen-idmod
Add download_asset unittest
49e6186
@shchen-idmod
Add more unittest for download_asset function
1fcfdf6
@shchen-idmod
Add missing changes from previous checkin
4439126
@shchen-idmod
Commented out downloading the big sif file code in example
6178f9b
@shchen-idmod
update codes based on feedback from Zhaowei
a555ac3
@shchen-idmod
rename filename and content from asset_id to md5
3e4924e
@shchen-idmod
change return type of generate_ac_from_md5 to idm ac type and add exa…
ab9a201 
…mple for sigunalrity
@shchen-idmod
Copy link
Collaborator Author

All tests passed: https://jenkins.apps.idmod.org/job/idmtools-Multibranch-Pipeline/view/change-requests/job/PR-2210/

ZDu-IDM
ZDu-IDM approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@ZDu-IDM ZDu-IDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shchen-idmod shchen-idmod merged commit b8d03c9 into InstituteforDiseaseModeling:dev Mar 20, 2024
4 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZDu-IDM ZDu-IDM ZDu-IDM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shchen-idmod @ZDu-IDM