Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis AOF fields. Provide further Telegraf customization? #76

Open
jasonroelofs opened this issue Jul 24, 2017 · 2 comments
Open

Redis AOF fields. Provide further Telegraf customization? #76

jasonroelofs opened this issue Jul 24, 2017 · 2 comments

Comments

@jasonroelofs
Copy link

I've run into a situation where I'd like to get more information out of Redis, specifically the AOF fields. I do see that I could write a custom plugin to pull this info but that feels like a lot of extra work when telegraf already exposes this info when so configured. Given telegraf and TOML supports multiple similar definitions, what do you think of adding an option to provide a file who's content will be appended to instrumentald_telegraf.toml?

Alternatively, what about making the fieldspass section for redis explicitly configurable or with a way to add more fields?

@janxious
Copy link
Contributor

You're specifically looking for the bits below?

$ redis-cli
127.0.0.1:6379> info
…
# Persistence
…
aof_enabled:0
aof_rewrite_in_progress:0
aof_rewrite_scheduled:0
aof_last_rewrite_time_sec:-1
aof_current_rewrite_time_sec:-1
aof_last_bgrewrite_status:ok
aof_last_write_status:ok
…

Adding configurability to our configuration on top of the configurability of telegraf is a thing we plan to do, but this would be our first. I have certainly pushed others to essentially take the telegraf output from instrumentald and make modifications as necessary after the fact if they need a more customized experience (say adding a service like riak).

Team Instrumental will have to noodle on this one. It's possible we should just include the rdb/aof bits by default.

@jasonroelofs
Copy link
Author

Yeah those are the fields I'm looking at.

Curious how you've pointed people towards modifying the generated telegraf config file. Unless I've missed something, it looks like that file is generated every time instrumentald is run? If there's an easy way to supply my own config I can definitely do that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants