Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

NATIVE-322: Test i18n module #116

Merged
merged 31 commits into from Aug 26, 2019
Merged

NATIVE-322: Test i18n module #116

merged 31 commits into from Aug 26, 2019

Conversation

steffenkleinle
Copy link
Member

No description provided.

@steffenkleinle steffenkleinle changed the title WIP: NATIVE-322: Test i18n module NATIVE-322: Test i18n module Aug 13, 2019
@steffenkleinle
Copy link
Member Author

steffenkleinle commented Aug 13, 2019 •
edited

So I am still not able to mock any dependency, so I can't test some stuff... I don't understand why this is not possible though. If you've got any suggestions please tell me :) E.g. mocking the I18nManager to test contentDirection or AppSettings to test watchClearCity. Both not really important tests imo, but anyway..

maxammann
maxammann suggested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet sure about shallow vs non-shallow but I kind of think we should continue as in the webapp and risk it.

babel.config.js Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/modules/i18n/__tests__/contentDirection.spec.js Outdated Show resolved Hide resolved
src/modules/i18n/components/__tests__/I18nProvider.spec.js Show resolved Hide resolved
src/modules/i18n/reducers/contentLanguageReducer.js Show resolved Hide resolved
src/modules/settings/AppSettings.js Outdated Show resolved Hide resolved
src/modules/test-utils/createAppSettingsMock.js Outdated Show resolved Hide resolved
@michael-markl michael-markl mentioned this pull request Aug 19, 2019
Merged
@michael-markl
Copy link
Member

@maxammann Who of us two will take this PR?

@michael-markl michael-markl merged commit ec588b1 into develop Aug 26, 2019
@michael-markl michael-markl deleted the NATIVE-322-TestI18n branch September 1, 2019 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael-markl michael-markl michael-markl approved these changes

@maxammann maxammann maxammann approved these changes

@a-kud a-kud Awaiting requested review from a-kud

@imnnquy imnnquy Awaiting requested review from imnnquy

@NKlug NKlug Awaiting requested review from NKlug

@vincentgierisch vincentgierisch Awaiting requested review from vincentgierisch

@thimmy687 thimmy687 Awaiting requested review from thimmy687

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@steffenkleinle @michael-markl @maxammann