Add SplitFspBin.py #4
Conversation
Taken from github.com/tianocore/edk2.git, commit 7431e4f Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
|
@vincent-j-zimmer We really would like to get that it would simplify our validation environment a lot. |
|
@nate-desimone-intel Can you take care of it. That would be awesome :) |
|
Hi All, It seems that SplitFspBin.py is used by a large number of UEFI boot loaders. Most of the feedback I have received is that the developers of those boot loaders would like SplitFspBin.py to remain in the EDK2 repository. Therefore, it seems the best coarse of action would be to maintain 2 copies of SplitFspBin.py, one copy here and one copy in https://github.com/tianocore/edk2/tree/master/IntelFsp2Pkg/Tools. This results in the question of which copy is the "official" copy, it doesn't make much sense to maintain 2 forks of this script. Naturally, we feel that since tianocore is an open source project, (whereas this repo is just used for distributing binaries,) tianocore is the best place to maintain the official copy. So... TLDR is lets keep all code contributions for changes to SplitFspBin.py under tianocore, then an Intel employee will cherry pick those changes here. So, next steps. @pgeorgi, please submit these two commits to tianocore: bd11836, and 6c3f698. For instruction on how to do this, please see here: https://raw.githubusercontent.com/tianocore/edk2/master/Contributions.txt TLDR is:
After those get merged to EDK2, I'll cherry-pick SplitFspBin.py to here. @pgeorgi, is it OK if I close this pull request? |
|
sure, let's do that. Thanks for sorting out a proper workflow |
|
The typo commit is merged and the others were decided against. @nate-desimone-intel, could you please copy the script in here? |
|
Hi @pgeorgi, I have committed SplitFspBin.py per your request. Accordingly, I am closing this one. |
With intel/FSP#4 merged, this allows using Intel's FSP repo (that we mirror) to build a complete BIOS ifd region with a simple coreboot build, automatically drawing in headers and binaries. This commit covers Apollolake, Coffeelake, Skylake, and Kabylake. Skylake is using Kabylake's FSP since its own is FSP 1.1 and Kabylake's also supports Skylake. Another candidate (given 3rdparty/fsp's content) is Denverton NS, but it requires changes to coreboot's FSP bindings to become compatible. Cannonlake, Whiskeylake require an FSP release. Change-Id: I8d838ca6555348ce877f54e95907e9fdf6b9f2e7 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/28593 Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> Reviewed-by: Naresh Solanki <naresh.solanki@intel.com> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Keeping this in the edk2 repo means that every non-edk2 project needs to pull and maintain it on its own.