This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
hiframes: better error reporting for getattr #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Report bound instancemethod references that were not immediately invoked (see #63) - Report undefined (unknown) data frame attributes access TODO: fill "unimplemented" lists, so HPAT can report "unimplemented yet" instead of "unknown attribute". Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
|
Also addresses #60. |
|
I don't think we should add this instance method restriction. Dead code elimination removes unused ones easily, and we can catch other invalid cases (e.g. returned ones). #63 seems like an issue with inlining. |
Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Signed-off-by: Iskander Sharipov <iskander.sharipov@intel.com>
|
I see there are still TODOs. Let me know when this is ready for review and merge. |
|
Not working on HPAT anymore, sorry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
immediately invoked (see Invalid result for HO function with bound instancemethod argument #63)
TODO: fill "unimplemented" lists, so HPAT can report
"unimplemented yet" instead of "unknown attribute".
Signed-off-by: Iskander Sharipov quasilyte@gmail.com