Merge 2cb4561 into 33742c4

IntelPython · Oct 29, 2019 · ba6e0a9 · ba6e0a9
2 parents 33742c4 + 2cb4561
commit ba6e0a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/hpat/datatypes/hpat_pandas_series_functions.py b/hpat/datatypes/hpat_pandas_series_functions.py
@@ -788,15 +788,17 @@ def hpat_pandas_series_groupby_impl(
     return hpat_pandas_series_groupby_impl
 
 
+@overload_method(SeriesType, 'isnull')
 @overload_method(SeriesType, 'isna')
 def hpat_pandas_series_isna(self):
     """
-    Pandas Series method :meth:`pandas.Series.isna` implementation.
+    Pandas Series method :meth:`pandas.Series.isna` and :meth:`pandas.Series.isnull` implementation.
 
     .. only:: developer
 
         Test: python -m hpat.runtests hpat.tests.test_series.TestSeries.test_series_isna1
         Test: python -m hpat.runtests hpat.tests.test_series.TestSeries.test_series_str_isna1
+        Test: python -m hpat.runtests hpat.tests.test_series.TestSeries.test_series_isnull1
 
     Parameters
     -----------
@@ -809,7 +811,7 @@ def hpat_pandas_series_isna(self):
          returns :obj:`pandas.Series` object
     """
 
-    _func_name = 'Method isna().'
+    _func_name = 'Method isna/isnull().'
 
     if not isinstance(self, SeriesType):
         raise TypingError(
@@ -818,7 +820,6 @@ def hpat_pandas_series_isna(self):
     if isinstance(self.dtype, (types.Integer, types.Float)):
 
         def hpat_pandas_series_isna_impl(self):
-
             return pandas.Series(numpy.isnan(self._data))
 
         return hpat_pandas_series_isna_impl

diff --git a/hpat/hiframes/pd_series_ext.py b/hpat/hiframes/pd_series_ext.py
@@ -661,11 +661,11 @@ def resolve_append(self, ary, args, kws):
     #     return signature(SeriesType(types.boolean))
 
     # alias of isna
-    @bound_function("series.isnull")
-    def resolve_isnull(self, ary, args, kws):
-        assert not kws
-        assert not args
-        return signature(SeriesType(types.boolean))
+    # @bound_function("series.isnull")
+    # def resolve_isnull(self, ary, args, kws):
+    #     assert not kws
+    #     assert not args
+    #     return signature(SeriesType(types.boolean))
 
     # @bound_function("series.notna")
     # def resolve_notna(self, ary, args, kws):