This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
CI on Windows #120
Merged
CI on Windows #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
approved these changes
Aug 12, 2019
|
Last commit - it is not new fail, I just missed one while marked them. |
dmitrii-zagornyi
suggested changes
Aug 13, 2019
hpat/tests/test_io.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| import unittest | |||
| import sys | |||
There was a problem hiding this comment.
Instead of sys.platform use platform.system(). This value is more predictable.
There was a problem hiding this comment.
@dmitrii-zagornyi Good catch!
"The output of sys.platform and os.name are determined at compile time. platform.system() determines the system type at run time."
https://stackoverflow.com/a/11674977/4428424
kozlov-alexey
pushed a commit
to kozlov-alexey/sdc
that referenced
this pull request
Oct 4, 2019
* added .yml for azure pipelines * skipped tests with errors on windows * added import sys * one more skipped test on Windows * using\ platform instead sys for Windows determaining * timeoutInMinutes: 0 * skipped 3 additional tests after merge changes from master * added import platform
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a configuration for CI on Windows with Azure Pipeline.
Example of run can be seen on this branch.