Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Skiping hanging tests #259

Closed
wants to merge 3 commits into from
Closed

Skiping hanging tests #259

wants to merge 3 commits into from

Conversation

AlexanderKalistratov
Copy link
Collaborator

Skip tests which starts to hang on Windows after rebase on Numba 0.46

@shssf
Copy link
Contributor

shssf commented Oct 29, 2019

Do you think it is better to implement some common procedure to enable/disable them?
It would be helpful to have a simple switch to control these tests.

@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Oct 29, 2019 •
edited by shssf
Loading

I don't see a reason to merge this since it is temporal solution for this week. If you need this for your development - use commit cherry picking

@kozlov-alexey kozlov-alexey added the FullyApproved Mark PR if all required approval exists label Oct 30, 2019
@AlexanderKalistratov
Copy link
Collaborator Author

@densmirn and @Hardcode84 could you please review and if you are fine - merge this MR since it blocking others?

@shssf
Copy link
Contributor

shssf commented Oct 30, 2019

I don't see a reason to merge this since it is temporal solution for this week. If you need this for your development - use commit cherry picking

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kozlov-alexey kozlov-alexey kozlov-alexey approved these changes

@densmirn densmirn densmirn approved these changes

@Hardcode84 Hardcode84 Awaiting requested review from Hardcode84

Assignees
No one assigned
Labels
FullyApproved Mark PR if all required approval exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexanderKalistratov @shssf @kozlov-alexey @densmirn