Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Skipped failed tests #91

Merged
merged 15 commits into from
Jul 15, 2019
Merged

Conversation

anmyachev
Copy link
Contributor

I propose so far to skip tests that fall. Thus, it will be possible to work in parallel to correct the tests and, for example, to do implementation of new features.

@fschlimb @Alexander-Makaryev @Vyacheslav-Smirnov what you think about it?

@fschlimb
Copy link
Contributor

Are there any features being worked on that depend on each other or any other non-merged PR?
If not, I do not see how this would help. We can develop features and accompanying tests independently.

@anmyachev
Copy link
Contributor Author

@fschlimb you have, for example, two PRs: #89, #90. It would be great to know if these changes break any tests. In the case when there are already tests in the master that do not pass, it is difficult to track the impact of new changes that will be pushed on the master.

@fschlimb
Copy link
Contributor

Our priority right now is to get things stabilized, e.g. fix issues in existing stuff. New features, improvements and optimizations are secondary (or less).

OK, let's be practical. It's probably easier to start from a green state. Let's merge this now.

However, from then on, we should merge only bug-fixes until all these tests are corrected an enabled.

Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fix needed" might be better than "needed fix", though.

@anmyachev
Copy link
Contributor Author

"fix needed" might be better than "needed fix", though.

I'll fix it now

@anmyachev
Copy link
Contributor Author

Our priority right now is to get things stabilized, e.g. fix issues in existing stuff. New features, improvements and optimizations are secondary (or less).

OK, let's be practical. It's probably easier to start from a green state. Let's merge this now.

However, from then on, we should merge only bug-fixes until all these tests are corrected an enabled.

@fschlimb OK I understood

@fschlimb fschlimb merged commit 456a12e into IntelPython:master Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants