Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint v4 #158

Closed
michaelgmiller opened this issue Jun 19, 2017 · 11 comments
Closed

Support eslint v4 #158

michaelgmiller opened this issue Jun 19, 2017 · 11 comments

Comments

@michaelgmiller
Copy link

When installing with eslint@4.0.0, I get:
npm WARN eslint-plugin-react-native@2.3.1 requires a peer of eslint@^3.17.0 but none was installed.

@Intellicode
Copy link
Owner

I'm planning to update as soon as my dependencies are also compatible with eslint 4.0.0, so far there are a few that are not compatible yet.

@noamokman
Copy link

Whats missing?

@Intellicode
Copy link
Owner

Basically, I'm using eslint-plugin-airbnb to lint the plugin itself, but it might not be worth it anymore to use it since it delays quickly updating to newer versions.

@kelset
Copy link

kelset commented Jul 24, 2017

Airbnb just released a new version, 15.1.0, that supports v4 - is there any other dependency you are waiting on? Would a PR help? Can't wait to test the new eslint :3

@ljharb
Copy link

ljharb commented Jul 24, 2017

@Intellicode nothing wrong with letting a new major version of eslint bake for a little while :-p

@Intellicode
Copy link
Owner

@kelset done!

@bspaulding, I had trouble getting your unit tests with regex options to work with the new eslint plugin, so please let me know if I broke something!

@sibelius
Copy link

sibelius commented Aug 3, 2017

any progress on this?

@sibelius
Copy link

sibelius commented Aug 3, 2017

react-native/no-inline-styles is working on v4

react-native/no-unused-styles is not

@Intellicode
Copy link
Owner

@sibelius can you provide details?

@sibelius
Copy link

it started working again, I restarted my webstorm

@bspaulding
Copy link
Contributor

@Intellicode Sorry I just saw this notification, just updated to eslint 4 with 3.1.0 of this, LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants