Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS Bridge: getItem returns the output amount of the pattern when no item is in the storage #598

Closed
Peekofwar opened this issue Apr 26, 2024 · 8 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists Priority-Medium
Milestone

Comments

@Peekofwar
Copy link

Describe

For some reason, when there are 0 x mekanism:enriched_tin for example, the getItem() function returns amount = 1. The issue seems to only occur when there is a crafting pattern for the item and there are none of the item in the system.

image
image

Steps to reproduce

  1. Add a pattern recipe to the RS system to allow it to craft the item.
  2. Lookup the item in the RS system through the Computercraft API.

Multiplayer?

No

Version

1.20.1-0.7.39r (Latest 1.20.1)

Minecraft, Forge and maybe other related mods versions

Forge 47.2.21

Screenshots or Videos

No response

Crashlog/log

No response

@Peekofwar Peekofwar added bug Something isn't working needs review Needs review from an Contributor labels Apr 26, 2024
@zyxkad zyxkad added Priority-Medium and removed needs review Needs review from an Contributor labels Apr 26, 2024
@zyxkad zyxkad self-assigned this Apr 26, 2024
@zyxkad
Copy link
Collaborator

zyxkad commented Apr 26, 2024

Not sure if @SirEndii did that on purpose.
I assume not, because the doc did not mention it

@zyxkad zyxkad modified the milestones: 0.7.x, 0.8r Apr 26, 2024
@zyxkad
Copy link
Collaborator

zyxkad commented Apr 26, 2024

Anyways, I believe that the ME/RS network needs some reforge, may fix that in 0.8

@SirEndii
Copy link
Member

Nope, not intended
I thought I already fixed that

@zyxkad
Copy link
Collaborator

zyxkad commented Apr 26, 2024

I thought I already fixed that

I double checked, you fixed the issue for AE, but not RS

@zyxkad zyxkad changed the title RS Bridge - getItem() Returning Incorrect Amount when 0 RS Bridge: getItem returns the amount of craftable item when no item is in the storage Apr 26, 2024
@zyxkad zyxkad changed the title RS Bridge: getItem returns the amount of craftable item when no item is in the storage RS Bridge: getItem returns the output amount of the pattern when no item is in the storage Apr 26, 2024
@SirEndii
Copy link
Member

Anyways, I believe that the ME/RS network needs some reforge, may fix that in 0.8

I already fixed several issues on 0.8

@zyxkad
Copy link
Collaborator

zyxkad commented Apr 26, 2024

k I'll check that later

@zyxkad
Copy link
Collaborator

zyxkad commented Apr 26, 2024

I see, this is a dup of #577

@zyxkad zyxkad closed this as completed Apr 26, 2024
@zyxkad zyxkad closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
@zyxkad zyxkad added the duplicate This issue or pull request already exists label Apr 26, 2024
@SirEndii
Copy link
Member

But remember, 0.8 is really wip
There is a lot of unfinished stuff which I didn't put in a different branch
For example the "new" system for the ME and RS bridge still needs some attention

@zyxkad zyxkad removed their assignment Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists Priority-Medium
Projects
None yet
Development

No branches or pull requests

3 participants