Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the active box while playing: Clicking/Dragging a box while the player is playing will cause CVAT to crash #5

Closed
elcie3 opened this issue Apr 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@elcie3
Copy link

elcie3 commented Apr 21, 2020

My actions before raising this issue

Expected Behaviour

The user should be able to change the box smoothly.

Current Behaviour

Changing the active box while playing causes CVAT to crash.
Error
Canvas is busy. Action: drag

Error: Canvas is busy. Action: drag
at au.activate (http://localhost:8080/cvat-ui.min.js:72:1336345)
at Vu.activate (http://localhost:8080/cvat-ui.min.js:72:1403114)
at Kc.activateOnCanvas (http://localhost:8080/cvat-ui.min.js:72:1321857)
at Kc.componentDidUpdate (http://localhost:8080/cvat-ui.min.js:72:1318546)
at yl (http://localhost:8080/cvat-ui.min.js:43:100837)
at t.unstable_runWithPriority (http://localhost:8080/cvat-ui.min.js:51:3465)
at Br (http://localhost:8080/cvat-ui.min.js:43:45441)
at gl (http://localhost:8080/cvat-ui.min.js:43:97113)
at ol (http://localhost:8080/cvat-ui.min.js:43:87489)
at http://localhost:8080/cvat-ui.min.js:43:45732

Steps to Reproduce (for bugs)

2 ways to reproduce the bug.
1st way.

  1. Create a new box but don't select it.
  2. Press the play button or the play hotkey.
  3. Select the box you made.
    2nd way.
  4. Create two boxes.
  5. Press play
  6. Select any of the boxes or switch from 1 box to another.

Context

When the user is using the 'tracking' feature that is added to CVAT, he/she might want to switch the box that is being tracked. With the current behavior this will result to a crash. This causes all the changes done in the session to be lost. This also results to bad user experience.

Your Environment

  • Git hash commit (git log -1):
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS):
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@jeffersonkeh
Copy link

Additional method of reproducing bug:

  1. Create a box.
  2. Click and drag the box. Do not release the mouse button.
  3. Change frame by pressing play, next frame, etc.

@johnanthonyjose johnanthonyjose added the bug Something isn't working label Apr 26, 2020
@meyg8600
Copy link

Commit hashes:
278e39e
9c0d2c1
1ef9631

Files edited:

  • cvat-ui/src/components/annotation-page/standard-workspace/canvas-wrapper.tsx
  • cvat-ui/src/containers/annotation-page/standard-workspace/objects-side-bar/object-item.tsx
  • cvat-ui/src/containers/annotation-page/standard-workspace/objects-side-bar/objects-list.tsx
  • cvat-canvas/src/typescript/canvasModel.ts
  • cvat-canvas/src/typescript/canvasView.ts
  • cvat-core/src/annotations-collection.js
  • cvat/apps/engine/static/engine/js/shapeMerger.js
  • cvat-ui/src/cvat-canvas.ts
  • cvat-ui/src/containers/annotation-page/top-bar/top-bar.tsx
  • cvat-ui/src/components/annotation-page/annotation-page.tsx
  • cvat-ui/src/components/create-task-page/styles.scss
  • cvat-ui/src/components/tasks-page/styles.scss
  • cvat-ui/src/styles.scss

What we did to resolve this issue:
This was solved with the same fixes as Issue #8. We based this on the steps taken from PR opencv#1371 from opencv/cvat to resolve similar issues opencv#1261 and opencv#1371 in opencv/cvat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants