Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to QueryBuilder #21

Merged
merged 14 commits into from Sep 11, 2022
Merged

Refactor to QueryBuilder #21

merged 14 commits into from Sep 11, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Sep 10, 2022

Todo:
Tests:

  • Select
  • Update
  • Insert
  • Delete

Implementations:

  • Select
  • Update
  • Insert
  • Delete

Refactoring Model to use this:

  • First
  • All
  • InsertOne
  • InsertMany
  • Update
  • Upsert?

Draft: needs tests, and Update, Insert & Upsert methods
@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

🦋 Changeset detected

Latest commit: 44435af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
d1-orm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 10, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 44435af
Status: ✅  Deploy successful!
Preview URL: https://f1ebbae0.d1-orm.pages.dev
Branch Preview URL: https://feat-querybuilder.d1-orm.pages.dev

View logs

@Skye-31 Skye-31 marked this pull request as ready for review September 11, 2022 14:58
Copy link
Contributor

@isaac-mcfadyen isaac-mcfadyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple comments but I'm very excited for these changes!

src/queryBuilder.ts Outdated Show resolved Hide resolved
src/queryBuilder.ts Outdated Show resolved Hide resolved
src/queryBuilder.ts Show resolved Hide resolved
@Skye-31 Skye-31 merged commit b2559ef into main Sep 11, 2022
@Skye-31 Skye-31 deleted the feat-querybuilder branch September 11, 2022 15:43
@github-actions github-actions bot mentioned this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants