Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing requestExitFullScreen message in CreativeMessage dictionary #437

Open
jakraskin opened this issue Oct 20, 2022 · 2 comments
Open

Missing requestExitFullScreen message in CreativeMessage dictionary #437

jakraskin opened this issue Oct 20, 2022 · 2 comments

Comments

@jakraskin
Copy link
Contributor

Hi IAB,

We noticed that the CreativeMessage dictionary does not currently contain a constant for requestExitFullScreen. Can we please update the sample code to include something like REQUEST_EXIT_FULLSCREEN in CreativeMessages? Having the constant explicitly defined would prevent creatives and players from potentially using different constants for requestExitFullScreen (e.g., REQUEST_EXIT_FULLSCREEN or REQUEST_EXIT_FULL_SCREEN).

Thanks!
Josh
@aronschatz
Copy link
Collaborator

The repo is open for pull requests, feel free to submit one to correct this.

@jakraskin jakraskin mentioned this issue Oct 20, 2022
Merged
@jakraskin
Copy link
Contributor Author

Thank you - I went ahead and submitted PR #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aronschatz @jakraskin