Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVLError caused by incompatibility with latest GVL or invalid file #393

Open
andreas-hartmann opened this issue May 19, 2023 · 6 comments
Open
Labels
bug Something isn't working

Comments

@andreas-hartmann
Copy link

andreas-hartmann commented May 19, 2023

We are experiencing:

GVLError.js:1 Uncaught (in promise) GVLError: Cannot read properties of undefined (reading 'consent')
    at new t (GVLError.js:1:647)
    at t.<anonymous> (GVL.js:1:4117)
    at GVL.js:1:1826
    at Object.next (GVL.js:1:1142)
    at s (GVL.js:1:635)

When loading the latest version of https://vendor-list.consensu.org/v2/vendor-list.json as published yesterday.
The issue appears to be caused by https://github.com/InteractiveAdvertisingBureau/iabtcf-es/blob/master/modules/core/src/GVL.ts#L602 where the purposes of each vendor are mapped to a lookup table of defined purposes. Unfortunately one of the vendors defines purpose 11 in this newest version of the GVL which is is not defined in that same file (only 1-10 are). This causes this error. The relevant vendor is:

        "164": {
            "id": 164,
            "name": "Outbrain UK Ltd",
            "purposes": [
                1,
                2,
                3,
                4,
                5,
                6,
                7,
                8,
                9,
                10,
                11
            ]

This is quite clearly an error in the GVL, but either way this library should not catastrophically fail in such a case. IMO there should be a softer behavior, such as a warning, a skipped vendor or some such solution.

@andreas-hartmann andreas-hartmann added the bug Something isn't working label May 19, 2023
@lhorzee
Copy link

lhorzee commented May 19, 2023

Same, the issue was appeared after using the new version 197, but 196 works well

@dmdabbs
Copy link

dmdabbs commented May 19, 2023

Same, the issue was appeared after using the new version 197, but 196 works well

The issue persists even with the new GVL revision with the mistakenly added Purpose 11 removed?

cc: @HeinzBaumann

@andreas-hartmann
Copy link
Author

We also rolled back to 196, didn't try removing the purpose though.

@HeinzBaumann
Copy link
Collaborator

There is new updated GVL posted today. It should be all fixed.

@andreas-hartmann
Copy link
Author

As a note, the new GVL has the same version 197 as the broken one but a new timestamp. It also contains other changes, so it's not clear to me why they didn't give it a new version number. Be aware of this in case your implementation is checking for the version.

@adriafolchmrf
Copy link

adriafolchmrf commented May 22, 2023

Following up on this, even though version 197 is correct in https://vendor-list.consensu.org/v2/vendor-list.json, when requesting it through https://vendor-list.consensu.org/v2/archives/vendor-list-v197.json the error still persist. Are there any plans to update this one as well?

cc: @HeinzBaumann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants