Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update Readme and Fix failed links #108

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[Doc] Update Readme and Fix failed links #108

merged 3 commits into from
Jul 27, 2023

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Jul 27, 2023

Motivation

Fix the readme refer to #107

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Ezra-Yu Ezra-Yu requested a review from gaotongxiao July 27, 2023 04:57
@Ezra-Yu Ezra-Yu changed the title [Doc] Update Reame and Fix failed links [Doc] Update Readme and Fix failed links Jul 27, 2023
gaotongxiao
gaotongxiao requested changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Also fix this link

README.md Outdated Show resolved Hide resolved
@Ezra-Yu
Copy link
Collaborator Author

Ezra-Yu commented Jul 27, 2023

image Also fix this link

done.

@Ezra-Yu Ezra-Yu requested a review from gaotongxiao July 27, 2023 06:40
@gaotongxiao gaotongxiao merged commit d1ec604 into open-compass:main Jul 27, 2023
1 check passed
go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
@Ezra-Yu @BunnyRunnerX
Update Readme and Fix failed links (open-compass#108)
61e2bc6 
* update reame and fix failed links

* update

* update review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaotongxiao gaotongxiao gaotongxiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ezra-Yu @gaotongxiao