Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bugs of multiple rounds of inference when using mm_eval #201

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

yyk-wew
Copy link
Contributor

@yyk-wew yyk-wew commented Aug 14, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Inference with --mm-eval arg leads to multiple rounds of running.

Modification

In slurm runner, the task reruns when job failure is detected, the related code is as below:
https://github.com/InternLM/opencompass/blob/4fc1701209adad832f7fca91640fac34331b8e29/opencompass/runners/slurm.py#L150-L152

And the output path is obtained by calling task.get_output_paths():
https://github.com/InternLM/opencompass/blob/4fc1701209adad832f7fca91640fac34331b8e29/opencompass/runners/slurm.py#L129-L131

However, in MultimodalInferTask, the returned path of get_output_paths method is different with the path of the output result.
The get_output_paths method returns:
https://github.com/InternLM/opencompass/blob/4fc1701209adad832f7fca91640fac34331b8e29/opencompass/tasks/mm_infer.py#L92-L95

And the result is dumped into:
https://github.com/InternLM/opencompass/blob/4fc1701209adad832f7fca91640fac34331b8e29/opencompass/tasks/mm_infer.py#L136-L139

Therefore, when the task is finished successfully, the get_output_paths directory does not exist since the result is saved somewhere else. Then the runner rerun the task.

So in this PR, we modify the saving path from work_dir to get_output_paths.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@YuanLiuuuuuu YuanLiuuuuuu merged commit 3a46b6c into open-compass:main Aug 16, 2023
1 check passed
go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants