[Feat] Support visualglm and llava for MMBench evaluation. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingfhu
reviewed
Aug 17, 2023
| return | ||
|
|
||
|
|
||
| class KeywordsStoppingCriteria(StoppingCriteria): |
Comment on lines
13
to
17
| Args: | ||
| conv_templates: Conversation class to build prompt. | ||
| conv_mode: Version control args for different version of LLaVA. | ||
| image_token_len: Number of tokens per image. | ||
| mm_use_im_start_end: | ||
| Config arg. Use start and end token when build prompt or not. |
There was a problem hiding this comment.
missing the type hint in docstring
There was a problem hiding this comment.
updated in the latest commit.
Comment on lines
13
to
16
| system_prompt (str): System prompt. | ||
| human_prompt (str): Human prompt. | ||
| image_prompt (str): Image prompt. | ||
| assistant_prompt (str): Assistant prompt. |
There was a problem hiding this comment.
missing default values in docstring
There was a problem hiding this comment.
updated in the latest commit.
| return False | ||
|
|
||
|
|
||
| @MM_MODELS.register_module('llava-7b-mmbench') |
There was a problem hiding this comment.
Suggested change
| @MM_MODELS.register_module('llava-7b-mmbench') | |
| @MM_MODELS.register_module('llava') |
There was a problem hiding this comment.
updated in the latest commit.
| from opencompass.registry import MM_MODELS | ||
|
|
||
|
|
||
| @MM_MODELS.register_module('visualglm-postprocessor') |
There was a problem hiding this comment.
We no longer need registry here
| from opencompass.registry import MM_MODELS | ||
|
|
||
|
|
||
| @MM_MODELS.register_module('visualglm-mmbench') |
There was a problem hiding this comment.
Suggested change
| @MM_MODELS.register_module('visualglm-mmbench') | |
| @MM_MODELS.register_module('visualglm') |
There was a problem hiding this comment.
updated in the latest commit.
1. Set `low_cpu_mem_usage` to False to address device issue. 2. Add docstring and type hints. 3. Rename class and remove registry.
yyk-wew
force-pushed
the
yyk/model_support
branch
from
2a4e4fc
to
4b1228f
Compare
|
|
||
| @MM_MODELS.register_module('llava') | ||
| class LLaVA(nn.Module): | ||
| """Inference code of LLaVA on MMBench. Need to clone LLaVA official repo |
There was a problem hiding this comment.
Docstring should also be changed accordingly.
There was a problem hiding this comment.
Done. Changed to "Inference code of LLaVA. Need to clone LLaVA official repo first."
YuanLiuuuuuu
approved these changes
Aug 21, 2023
go-with-me000
pushed a commit
to go-with-me000/opencompass
that referenced
this pull request
Oct 9, 2023
* [Feat] Support visualglm inference on MMBench. * [Feat] Support llava inference on MMBench. * [Fix] Fix pre-commit format. * [Fix] Add docstring for llava * [Fix] Fix multi-process inference error of LlaVA and add comments. 1. Set `low_cpu_mem_usage` to False to address device issue. 2. Add docstring and type hints. 3. Rename class and remove registry. * [Fix] Pre-commit fix. * [Fix] add forward entry, add dynamic import to seedbench * [Fix] Fix pre-commit. * [Fix] Fix missing context. * [Fix] Fix docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: