Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] use sympy only when necessary #255

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[Fix] use sympy only when necessary #255

merged 1 commit into from
Aug 24, 2023

Conversation

gaotongxiao
Copy link
Collaborator

as sympy is not in requirement.

tonysy
tonysy approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaotongxiao gaotongxiao merged commit bd47a00 into open-compass:main Aug 24, 2023
1 check passed
@gaotongxiao gaotongxiao deleted the fix_game24 branch August 24, 2023 02:15
go-with-me000 pushed a commit to go-with-me000/opencompass that referenced this pull request Oct 9, 2023
@gaotongxiao @BunnyRunnerX
use sympy only when necessary (open-compass#255)
127a523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonysy tonysy tonysy approved these changes

@liushz liushz Awaiting requested review from liushz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaotongxiao @tonysy