Support intern lanuage model #51
Conversation
| from opencompass.models.base import BaseModel, LMTemplateParser | ||
| from opencompass.registry import MODELS | ||
|
|
||
| sys.path.append(os.getcwd() + '/InternLM/') |
There was a problem hiding this comment.
I'd suggest moving this line into the InternLM.init function, so that sys.path would be modified only when necessary. Otherwise, it may result in some unexpected behavior for general users who don't need this repo at all.
|
|
||
|
|
||
| @MODELS.register_module(name=['intern_model']) | ||
| class intern_model(BaseModel): |
There was a problem hiding this comment.
The name of the class should be in the camel case.
e.g. InternLM
| sys.path.append(os.getcwd() + '/InternLM/') | ||
|
|
||
|
|
||
| @MODELS.register_module(name=['intern_model']) |
There was a problem hiding this comment.
Delete this line, we are using new config system and do not need Registry any more
| model_config: Optional[str] = None, | ||
| tokenizer_type: Optional[str] = 'v7', | ||
| meta_template: Optional[Dict] = None): | ||
| root = os.getcwd() + '/opencompass/models/intern/model/' |
There was a problem hiding this comment.
Never hardcode anything. Just let users specify it in the parameter.
go-with-me000
force-pushed
the
cky/support_internLM
branch
from
bac9fa9
to
8d4905e
Compare
opencompass/models/intern_model.py
Outdated
| from opencompass.models.base import BaseModel, LMTemplateParser | ||
|
|
||
|
|
||
| class internLM(BaseModel): |
There was a problem hiding this comment.
| class internLM(BaseModel): | |
| class InternLM(BaseModel): |
configs/eval_internLM.py
Outdated
| from .datasets.nq.nq_gen import nq_datasets | ||
|
|
||
| datasets = [*nq_datasets] |
There was a problem hiding this comment.
| from .datasets.nq.nq_gen import nq_datasets | |
| datasets = [*nq_datasets] | |
| from .datasets.collections.base_medium import datasets |
Like how it was done in
https://github.com/InternLM/opencompass/blob/main/configs/eval_internlm_7b.py
datasets = [*nq_datasets]
* support internLM * support internLM * simplify intern model files * update storage_manager * support internLM * Modify the file organization structure * support internLM * support internLM * support internLM * support internLM * change some details
To support the evaluation and loading of internal models.
Before PR:
[y] Pre-commit or other linting tools are used to fix the potential lint issues.
[y] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[y] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[y] The documentation has been modified accordingly, like docstring or example tutorials.
After PR:
[y] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[y] CLA has been signed and all committers have signed the CLA in this PR.