Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement float arithmetic #52

Merged
merged 1 commit into from Mar 5, 2022
Merged

implement float arithmetic #52

merged 1 commit into from Mar 5, 2022

Conversation

6293
Copy link
Contributor

@6293 6293 commented Mar 1, 2022 •
edited

Closes #4
Closes #12
Closes #17

@6293 6293 changed the title support IeeeOct, filter NaN implement float arithmetic Mar 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #52 (f76a87f) into master (0d74fd5) will increase coverage by 3.9%.
The diff coverage is 68.2%.

❗ Current head f76a87f differs from pull request most recent head 95dfae5. Consider uploading reports for the commit 95dfae5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #52     +/-   ##
========================================
+ Coverage    24.9%   28.8%   +3.9%     
========================================
  Files          18      18             
  Lines        4210    4215      +5     
========================================
+ Hits         1050    1216    +166     
+ Misses       3160    2999    -161
Impacted Files Coverage Δ
src/isa/exec.rs 41.0% <0.0%> (ø)
src/isa/flags.rs 1.4% <ø> (+1.1%) ⬆️
src/reg/core_regs.rs 23.3% <44.1%> (+1.3%) ⬆️
src/data/number.rs 47.9% <56.1%> (+1.8%) ⬆️
src/data/arithm.rs 76.0% <83.9%> (+27.3%) ⬆️
src/lib.rs 34.8% <0.0%> (+30.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d74fd5...95dfae5. Read the comment docs.

@6293 6293 marked this pull request as ready for review March 2, 2022 13:31
@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus epic Epic task labels Mar 5, 2022
@dr-orlovsky dr-orlovsky added this to In progress in AluVM via automation Mar 5, 2022
@dr-orlovsky dr-orlovsky modified the milestones: 0.5.0, 1.0.0 Mar 5, 2022
dr-orlovsky
dr-orlovsky approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 95dfae5

src/data/number.rs
type Err = LiteralParseError;

fn from_str(s: &str) -> Result<Self, Self::Err> {
Ok(if s.contains(&['p'][..]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this can be b"p"

AluVM automation moved this from In progress to Reviewer approved Mar 5, 2022
@dr-orlovsky dr-orlovsky merged commit c6fc082 into AluVM:master Mar 5, 2022
AluVM automation moved this from Reviewer approved to Done Mar 5, 2022
@dr-orlovsky dr-orlovsky removed this from Done in AluVM Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
*consensus* Issues affecting distributed concensus epic Epic task
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Improve float to Number conversions Complete BFloat16 arithmetics Introduce ieee::Oct float type
3 participants
@6293 @codecov-commenter @dr-orlovsky