Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComposableLora & Cutoff Extensions not working with Krita Plugin #138

Open
DreamOfGit opened this issue Apr 3, 2023 · 6 comments
Open
Labels
bug Something isn't working

Comments

@DreamOfGit
Copy link

Error running process: \stable-diffusion-webui\extensions\stable-diffusion-webui-composable-lora\scripts\composable_lora_script.py
Traceback (most recent call last):
File "\stable-diffusion-webui\modules\scripts.py", line 417, in process
script.process(p, *script_args)
TypeError: ComposableLoraScript.process() missing 3 required positional arguments: 'enabled', 'opt_uc_text_model_encoder', and 'opt_uc_diffusion_model'

To Reproduce just put any Lora in your Krita prompt.

@Interpause
Copy link
Owner

Whats the commit version for webUI? I'm aware at some point the script API changed. But also, can you check the error does not occur when using the webUI?

@DreamOfGit
Copy link
Author

DreamOfGit commented Apr 4, 2023

Doesn't happen on WebUI, I have no errors with WebUI.
I'm on HEAD / latest.

(The Krita dockers are much cleaner btw - I am only recently coming back to this extension, it's really nice to use, great job)

@Interpause
Copy link
Owner

Hm, so LoRAs might be an always enabled script that injects into script args. When the frontend makes the API request, it wouldn't know the script args for LoRA. I guess the easiest way would be to detect for the LoRA script in my backend and just set it to always be enabled in the frontend.

@rexelbartolome
Copy link

rexelbartolome commented Apr 9, 2023

I have my webui to be auto updated and I'm on the controlnet commit of this krita extension and my Lora's don't throw any errors when I type the <lora:xyz> then trigger word on my prompts for generating on both img2img and txt2img on their respective dockers.

Might be because of your extension that interferes with the native Lora implementation? I don't have that installed
image

@DreamOfGit
Copy link
Author

DreamOfGit commented Apr 9, 2023

Can confirm. That extension was the issue.

After disabling it, I ran into a new error with the 'cutoff' extension

Error running process: \stable-diffusion-webui\extensions\sd-webui-cutoff\scripts\cutoff.py
Traceback (most recent call last):
File "\stable-diffusion-webui\modules\scripts.py", line 417, in process
script.process(p, *script_args)
TypeError: Script.process() missing 8 required positional arguments: 'enabled', 'targets_', 'weight', 'disable_neg', 'strong', 'padding', 'intp', and 'debug'

I think this lowers the priority of this issue quite a bit.
Composables and Cutoff are pretty useful integrations.. but they are not the base web-ui.. so this issue is more QOL / Nice-to-have.. not a fundamental issue.

Good catch @rexelbartolome .

Thanks for reading / following up @Interpause

@DreamOfGit DreamOfGit changed the title Lora in Prompts Not Working ComposableLora & Cutoff Extensions not working with Krita Plugin Apr 9, 2023
@DreamOfGit
Copy link
Author

Updating Issue title to be more accurate.

@Interpause Interpause added the bug Something isn't working label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants