Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete genesisSlotNo and genesisBlockNo #78

Closed
edsko opened this issue Feb 6, 2020 · 1 comment
Closed

Delete genesisSlotNo and genesisBlockNo #78

edsko opened this issue Feb 6, 2020 · 1 comment
Assignees

Comments

@edsko
Copy link
Contributor

edsko commented Feb 6, 2020

These two functions should be gone for two reasons:

  1. They are very confusing. genesisPoint (admittedly not defined here, but in ouroboros-network) refers to the point corresponding to the genesis config, i.e., before the first block on the chain. By contrast, genesisSlotNo and genesisBlockNo refer to the first block on the chain. This has led to a host of off-by-one errors.

  2. Nothing in the core infrastructure should depend on the exact values of the slot number and block number of the first block on the chain. Instead, such details should live in specific ledger implementations (Shelley, Byron, whatever).

@edsko
Copy link
Contributor Author

edsko commented Feb 20, 2020

This was closed in #79.

@edsko edsko closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant