You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These two functions should be gone for two reasons:
They are very confusing. genesisPoint (admittedly not defined here, but in ouroboros-network) refers to the point corresponding to the genesis config, i.e., before the first block on the chain. By contrast, genesisSlotNo and genesisBlockNo refer to the first block on the chain. This has led to a host of off-by-one errors.
Nothing in the core infrastructure should depend on the exact values of the slot number and block number of the first block on the chain. Instead, such details should live in specific ledger implementations (Shelley, Byron, whatever).
The text was updated successfully, but these errors were encountered:
These two functions should be gone for two reasons:
They are very confusing.
genesisPoint
(admittedly not defined here, but inouroboros-network
) refers to the point corresponding to the genesis config, i.e., before the first block on the chain. By contrast,genesisSlotNo
andgenesisBlockNo
refer to the first block on the chain. This has led to a host of off-by-one errors.Nothing in the core infrastructure should depend on the exact values of the slot number and block number of the first block on the chain. Instead, such details should live in specific ledger implementations (Shelley, Byron, whatever).
The text was updated successfully, but these errors were encountered: