Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtraMigrationssimplified and renamed #1489

Closed
Tracked by #1420
kderme opened this issue Aug 22, 2023 · 0 comments · Fixed by #1496
Closed
Tracked by #1420

ExtraMigrationssimplified and renamed #1489

kderme opened this issue Aug 22, 2023 · 0 comments · Fixed by #1496

Comments

@kderme
Copy link
Contributor

kderme commented Aug 22, 2023 •
edited
Loading

The ExtraMigrations can be simplified. For example emRan isn't needed since the migration is attempted only once anyway. Also it doens't need to be mutable var. Simply initiating the other 2 values in the SyncEnv should be fine.
@kderme kderme mentioned this issue Aug 22, 2023
Closed
11 tasks
@kderme kderme changed the title The ExtraMigrations can be simplified. For example emRan isn't needed since the migration is attempted only once anyway. Also it doens't need to be mutable var. Simply initiating the other 2 values in the SyncEnv should be fine. ExtraMigrationssimplified and renamed Aug 22, 2023
@kderme kderme mentioned this issue Sep 5, 2023
Merged
9 tasks
@Cmdv Cmdv mentioned this issue Sep 5, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify extra migrations IntersectMBO/cardano-db-sync
1 participant
@kderme