-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make revision for plutus-core #105
Comments
We very much plan to do this. Unfortunately revisions from CHaP don't get picked up in |
This is indeed very annoying and the current practice of cargo-culting constraints is not optimal. What we do see with more recent package release to CHaP, that proper bounds are actually start to be introduced. Revisions would certainly help in the interim, and revisions are being addressed in input-output-hk/haskell.nix#1775. Thus we should be able to have this soon. |
@michaelpj it’s actually worse in the sense that haskell.nix barf in presence of non-hackage revisions. If haskell.nix just ignored them we could at least start collecting revisions into chap to save non-nix users. 😿😿😿 |
Well, we could initially just drop the barfing, no? I think the risk we'd be running is that haskell.nix based projects would work in the shell, but fail to work in CI. |
Saving the non-nix users doesn't help us much since all our projects also build with Nix, so they'll need to cargo cult the constraints anyway 🤷 |
But there are also other consumers of e.g. Please start to pay attention to the other users of "cardano platform" libraries then just IOG. |
We are paying attention, and we are doing things that help you, we're just doing them in the order that helps us the most also 🤷 |
I believe haskell.nix supports this now, and we want a revision for plutus-core for the new cardano-crypto-class, so maybe we can combine this |
Actually I'm confused about what's happening here, as plutus-core has had |
https://github.com/input-output-hk/cardano-haskell-packages/pull/140 is open, not sure if there's something to add there to fix this issue as well. |
The original issue was not about allowing new stuff, it's about disallowing dependencies packages don't work with. E.g. precise lower bounds would be a great start. |
<3 |
I did a lot of such revisions recently, most of the constraints are now not needed. |
Reading
cardano-node
'scabal.project
I noticed:Wouldn't it best for everyone to make the revision for
plutus-core
incardano-haskell-packages
then copying that constraint ~everywhere.That applies to most of constraints in https://github.com/input-output-hk/cardano-node/blob/f7496b44538cf490eb6be9199783f37bad77862e/cabal.project#L85-L107
I'd expect those bounds to be corrected in the repository (with revisions).
EDIT: I'm very frustrated that I cannot just add the
repository cardano-haskell-packages
and useplutus-core
orcardano-api
, but I still need to add a bunch of constraints which are virtually impossible to discover reliably.The text was updated successfully, but these errors were encountered: