Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Unclear --signed-tx-file argument to governance verify-poll #5183

Closed
mkoura opened this issue May 3, 2023 · 1 comment
Closed

[BUG] - Unclear --signed-tx-file argument to governance verify-poll #5183

mkoura opened this issue May 3, 2023 · 1 comment
Labels
8.0.0 issues in 8.0.0 CLI comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee

Comments

@mkoura
Copy link
Contributor

mkoura commented May 3, 2023

Internal

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
The cardano-cli governance verify-poll has --signed-tx-file FILE argument. The corresponding helptext states:

Filepath to a signed transaction carrying a valid poll answer.

However the FILE value can be both signed tx file and tx body. The verify-poll command checks the "required signers" listed in the tx, not the actual signatures.

Expected behavior
The argument should be named e.g. --tx-file and command help should state that the argument accepts both signed tx and tx body.

System info:

  • OS Name: Linux
  • OS Version: Fedora 37
  • Node version: 6f05a08
  • CLI version: 6f05a08
@mkoura mkoura added CLI type: bug Something is not working user type: internal Created by an IOG employee comp: cardano-cli 8.0.0 issues in 8.0.0 labels May 3, 2023
@mkoura
Copy link
Contributor Author

mkoura commented May 7, 2023

Fixed on master by #5184

@mkoura mkoura closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0.0 issues in 8.0.0 CLI comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

No branches or pull requests

1 participant