Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRep Registration: DRep Metadata Builder #497

Closed
Thomas-Upfield opened this issue Mar 18, 2024 · 8 comments
Closed

DRep Registration: DRep Metadata Builder #497

Thomas-Upfield opened this issue Mar 18, 2024 · 8 comments
Labels
Become a DRep (metadata builder and upload pages) relating to the EPIC named MILESTONE This is a Milestone, and there will be a corresponding milestone linked to this ticket Ready for staging This indicates that issue has been tested and might be safely transfered to staging

Comments

@Thomas-Upfield
Copy link

Thomas-Upfield commented Mar 18, 2024

As someone who wishes to register to vote on behalf of myself and others

I want an easy to use interface I can use as part of my registration process to create DRep metadata for my registration

So that I can easily create metadata that does not contain formatting errors

Given that I am on the DRep, Rules and Responsibilities page

When I press the Continue to Register button

Then I will be directed to the About You page which will consist of a form where I will be able to input all the data I need to complete my DRep metadata

Given that I am on the Register to Vote on Behalf of Yourself and Others, About You page

When I fill in all of the required information and press Continue

Then I will be directed to a page where I can download my metadata

Given that I am on the Register to Vote on Behalf of Yourself and Others, About You page

When I fill in all of the required information and press Continue

Then the metadata will be created in a format that aligns with CIP-100 and CIP-XXX* and cashed by GovTool for use later in the workstream.

*This CIP is the DRep Metadata Cip that has not yet been assigned a number.

Given that I am on the Register to Vote on Behalf of Yourself and Others, About You page

When I leave the the required fields blank

Then I will be unable to press continue

Given that I am on the Register to vote on behalf of myself and others, Storing Your Information page

When I press the button to download my DRep Metadata

Then the metadata will be downloaded

There is a DRep metadata builder which builds metadata to community standards, and also hashes it.

@m-i-k-e
Copy link

m-i-k-e commented Mar 19, 2024

@m-i-k-e
Copy link

m-i-k-e commented Mar 19, 2024

@MSzalowski I've been told by @Ryun1 that there is some error checking to limit the destination sites to IPFS and Github. Is this true? If so, is there any Github ticket for it? We don't have any text to inform the users about this in the design as of yet.

@Ryun1
Copy link
Member

Ryun1 commented Mar 19, 2024

this is just a temporary measure, we will find a solution around it
we will talk it over next week

@Thomas-Upfield Thomas-Upfield added MILESTONE This is a Milestone, and there will be a corresponding milestone linked to this ticket Become a DRep (metadata builder and upload pages) relating to the EPIC named labels Mar 21, 2024
@Sworzen1 Sworzen1 self-assigned this Mar 26, 2024
@pmbinapps pmbinapps self-assigned this Mar 26, 2024
@pmbinapps
Copy link

OK - registration with provided data , Jam record

Visual Aspects:
Positive Scenarios:

OK Initial Page: DRep, Rules and Responsibilities Page

OK Appearance "Continue' to Register" button.
Layout, readability page.
About You Page

OK Clear labeling required fields.
OK Form layout ease use.
OK Readability, alignment text, input fields.
OK Downloading Metadata Page

OK Visibility, clarity download button.
OK Layout, appearance page metadata generation.
OK Format, readability downloaded metadata.
OK DRep Metadata Builder

OK Visual presentation metadata builder interface.

NOT OK - Voting power is shown, (not required on design)

![Image](https://github.com/InterseWe ctMBO/govtool/assets/82152577/f54f9f75-b858-42ab-af18-218636e84545)

Negative Scenarios:

Initial Page: DRep, Rules and Responsibilities Page
OK Visual glitches not appearing
OK Visual indication required fields left blank.
OK Appearance error messages invalid inputs.
OK Downloading Metadata Page
OK Visual indication metadata download fails.
OK Layout issues, errors metadata download. - NOT OCCURRING

DRep Metadata Builder
Visual feedback metadata building fails. - NOT OCCURRING
Appearance error messages metadata creation.

Functional Aspects:
Positive Scenarios:

Initial Page: DRep, Rules and Responsibilities Page

Click "Continue" button, redirection next page.
About You Page

OK Fill required fields, successful redirection pressing "Continue."
OK Metadata created, stored correctly upon completion.
OK Downloading Metadata Page

OK Press download button, successful metadata download.
OK Downloaded metadata aligns standards.
OK DRep Metadata Builder

OK Metadata building valid inputs, correct hashing.
OK Compatibility built metadata system.

Negative Scenarios:

OK Initial Page: DRep, Rules and Responsibilities Page

OK "Continue" button disabled prerequisites met.

OK Leave required fields blank, "Continue" button remains disabled, prompts completion.
OK Enter invalid data, appropriate error handling.

Downloading Metadata Page

OK Downloading metadata not available, appropriate error handling.. - NOT OCCURRING
OK Error handling metadata download fails, encounters issues.. - NOT OCCURRING
OK DRep Metadata Builder

OK Not matching data check

Image

@MSzalowski
Copy link
Contributor

@m-i-k-e @Ryun1 The solution for that problem is now being developed.
First step is the creation of the validation metadata minimal backend delivered with this PR - #599.

That will allow to validate URLs from anywhere in the world allowing users to store their metadata wherever they want to.

Next step is to deliver that minimal backend somewhere in the cloud.
And then - adjust current metadata validation to that minimal backend and whitelist in CSP only that backend that would work as a proxy.

@MSzalowski
Copy link
Contributor

@pmbinapps

NOT OK - Voting power is shown, (not required on design)

Could you please retest that against that issue? Seems like it has been already fixed.

@pmbinapps
Copy link

To check:

NOT OK - Voting power is shown, (not required on design)

Image

OK with Retirement:

Image

@pmbinapps pmbinapps added the Ready for staging This indicates that issue has been tested and might be safely transfered to staging label Apr 8, 2024
@MSzalowski
Copy link
Contributor

Closed as dev done and already on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Become a DRep (metadata builder and upload pages) relating to the EPIC named MILESTONE This is a Milestone, and there will be a corresponding milestone linked to this ticket Ready for staging This indicates that issue has been tested and might be safely transfered to staging
Projects
Status: In staging
Development

No branches or pull requests

6 participants