Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking maxMajorPV in the header envelopeCheck #325

Open
nfrisby opened this issue Oct 26, 2022 · 1 comment
Open

Stop checking maxMajorPV in the header envelopeCheck #325

nfrisby opened this issue Oct 26, 2022 · 1 comment
Labels
technical debt Technical debt

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Oct 26, 2022

(This tech debt issue is only on the now unused Jira, so I'm creating this Issue instead.)

See IntersectMBO/ouroboros-network#3891 (comment) for more context.

@nfrisby nfrisby added the technical debt Technical debt label Oct 26, 2022
@nfrisby
Copy link
Contributor Author

nfrisby commented Oct 26, 2022

@amesgen and I considered some possibilities.

  • It seems premature to reject a block/transaction that contains a ledger proposal that uses a protocol version beyond the maximum.

  • My initial intuition was that ticking across the epoch boundary (which is when the actual protocol version would increase beyond our local limit) should fail in this case. But at the moment, ticking cannot fail. If it could fail here, then in this particular case I think node should simply shutdown, with a message that the software needs to be updated.

  • Maybe the ChainSel logic---which is where the most fundamental tick happens---could check for this and raise a proper exception there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Technical debt
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant