Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap GSM tech debt #964

Open
1 of 10 tasks
nfrisby opened this issue Feb 22, 2024 · 1 comment
Open
1 of 10 tasks

Bootstrap GSM tech debt #964

nfrisby opened this issue Feb 22, 2024 · 1 comment
Labels
good first issue Good for newcomers technical debt Technical debt

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Feb 22, 2024

Taken from #808 (comment), upon clicking the "Merge when ready" button.

  • s-r-p stanzas (see Add the pre-Genesis State Machine for bootstrap peers #808 (comment))
  • Either move the GSM logic into the ChainDB and keep the GSM arguments as part of the ChainDB arguments (which would be encapsulated inside of openChainDB) or remove the argument from the ChainDB arguments and keep it as a NodeKernel-level thing.
  • move the anti-thundering herd delay into the Diffusion Layer, between the two states CaughtUp and OnlyBootstrap
  • regression tests (code review and ad-hoc manual testing has already evidenced that they're currently correct):
    • realMarkerFileView regression tests
    • initializationLedgerJudgement regression tests
    • realDurationUntilTooOld regression tests
    • The ChainSync client should signal idle exactly when and only when the MsgAwaitReply is processed.
    • The ChainSync client subsequently should signal no-longer-idle exactly when and only when the next message is received.
  • switch to quickcheck-dynamic and/or upstream the io-sim-based QSM module #1149
  • use ArbitraryLedgerStateJudgement from ouroboros-network:sim-tests-lib
@jasagredo
Copy link
Contributor

  • Either move the GSM logic into the ChainDB and keep the GSM arguments as part of the ChainDB arguments (which would be encapsulated inside of openChainDB) or remove the argument from the ChainDB arguments and keep it as a NodeKernel-level thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers technical debt Technical debt
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants