Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds unit test to check for phantom connections #4757

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Adds unit test to check for phantom connections #4757

merged 2 commits into from
Jan 8, 2024

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Dec 18, 2023 •
edited by coot

Description

This PR adds a unit test that is able to find the p2p bug if one adds a threadDelay to the outbound governor code.

Links

@bolt12 bolt12 requested a review from coot as a code owner December 18, 2023 15:07
@coot coot added testing outbound-governor Issues / PRs related to outbound-governor labels Dec 22, 2023
coot
coot approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolt12 bolt12 added this pull request to the merge queue Dec 22, 2023
@coot coot removed this pull request from the merge queue due to a manual request Dec 22, 2023
@bolt12 bolt12 mentioned this pull request Jan 8, 2024
Open
@bolt12 bolt12 enabled auto-merge January 8, 2024 12:54
@bolt12 bolt12 added this pull request to the merge queue Jan 8, 2024
Merged via the queue into master with commit 7cf9071 Jan 8, 2024
9 checks passed
@bolt12 bolt12 deleted the bolt12/p2p-bug-test branch January 8, 2024 15:27
@coot coot linked an issue Jan 22, 2024 that may be closed by this pull request
We should also have a test that checks that a peer is added to the established set #4766
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@bolt12 bolt12

Labels
outbound-governor Issues / PRs related to outbound-governor testing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should also have a test that checks that a peer is added to the established set
2 participants
@bolt12 @coot