Doc: Handshake should pass TRUE for initiatorOnlyDiffusionMode #4790
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The network-spec.pdf document describes the handshake protocol as passing a bool flag for
initiatorAndResponderDiffusionMode
. According to the haskell code, this should really beinitiatorOnlyDiffusionMode
since we should passTRUE
for requesting a unidirectional connection. I've confirmed with @karknu that this corrects a misunderstanding in the spec doc.Checklist