Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase cleanup #4792

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Codebase cleanup #4792

merged 6 commits into from
Jan 29, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 29, 2024

Description

  • Fixed unused extension warnings
  • ouroboros-network: shadowing binding due to an import
  • ouroboros-network: removed not needed brackets
  • ouroboros-network: consolidate imports
  • ouroboros-network-protocols: removed not used modules

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot enabled auto-merge January 29, 2024 09:25
@coot coot added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 3b67786 Jan 29, 2024
9 of 10 checks passed
@coot coot deleted the coot/cleanup branch January 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants