Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Download Mini Protocol #62

Closed
7 tasks done
coot opened this issue Nov 15, 2018 · 2 comments
Closed
7 tasks done

Block Download Mini Protocol #62

coot opened this issue Nov 15, 2018 · 2 comments
Assignees

Comments

@coot
Copy link
Contributor

coot commented Nov 15, 2018

net_impl_protocol_block_download
Implement the mini-protocol for block body download (in sim)

This is the application level protocol for fetching ranges of blocks from another peer.

Ultimately this is a relatively simple protocol, however the final design of this protocol must be informed by the block fetching logic. See #66. Its expression relies on the framework for expressing mini-protocols. See #61.

The completion criteria for this work package is that:

  • it has an interface that is deemed satisfactory for use by the block fetch logic. This relies on PoC work on the block fetch logic.
  • tests in simulation that it can correctly fetch ranges of a chain, and correctly reports failure on ranges not in the current chain
  • tests in simulation that multiple requests can be outstanding at once

Testing the mini protocol in isolation should cover multiple integration levels.

This epic is split into 3 tasks:

  • direct,
  • via typed Peer with connect
  • codec in simulation
  • via local pipe
@coot coot self-assigned this Nov 15, 2018
@coot
Copy link
Contributor Author

coot commented Nov 15, 2018

#50 - streaming in sim
#31 - typed streaming (no latency hiding)
#52 - typed request / response protocol

@coot coot added the enhancement New feature or request label Nov 15, 2018
@coot coot added product-backlog and removed enhancement New feature or request labels Dec 6, 2018
@coot coot mentioned this issue Dec 21, 2018
@coot coot closed this as completed Feb 25, 2019
@coot
Copy link
Contributor Author

coot commented Feb 25, 2019

PR #319 - block fetch mini protocol using typed-protocols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant