Fighters can attack a ship in another system

[tomyeltz]

Description

Fighters (the objects, not the "Teeny Fighter" ships) don't have a SystemId attribute and therefore can attack ships that are in another system. The fighters appear to swarm around and fire at nothing in their system while the target ship in the other system appears to be taking fire (and damage) from all over with no visible combatants (plenty of tracers, though!).

This can be observed in the attached save file, where a swarm of fighters fly around and shoot at apparently nothing in NG4 while the Bethlehem Steel takes fire in the STARGATE system.

FighersAttackingShipInAnotherSystem.space.zip

Flavour affected

Steam

Operating System

Mac OS X

Version

Alpha 7

Is it something that used to work before?

N/A, multi-system simulation did not exist before Alpha 7

Expected behavior

Fighters should not be aware of ships in another system or attack them.

Actual behavior

Fighters are aware of ships in another system and attack them.

Repro steps

1. Get two friendly ships
2. Jump one to another system
3. Spawn/wait for a hostile ship that can launch fighters in one system
4. Somehow maneuver the hostile ship/fighters to the coordinates of the ship in the other system and watch the confusing fireworks

[jknotten]

I've just started looking into this one and I was just wondering whether these steps might also cause the problem:

1. Start with two friendly ships in one system.
2. Start a battle with a ship with hostile fighters.
3. Jump your friendly ship that is being targetted by the fighters to another system.
4. The fighers continuing to target that ship even though it's not there.

The fighters do know which system they're in, this is because the way it's structured is that fighters are world objects that belong to a layer ( a free space layer, when they're launched) and layers have system ids.

[jknotten]

This should be fixed in Alpha 8.

[tomyeltz]

You know, I probably should have considered inheritance more strongly since the logistics drones clearly know whether their target is in the same system or not while also lacking a SystemId attribute.

I will see if I can get repro this with the proposed alternative steps. Yep, that works, too.

[tomyeltz]

Working perfectly. Thanks!