Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP-512] Implement template files for emails #624

Closed
wants to merge 1 commit into from
Closed

[IP-512] Implement template files for emails #624

wants to merge 1 commit into from

Conversation

daniel89fg
Copy link
Contributor

@daniel89fg daniel89fg commented Apr 13, 2018

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@Kovah
Copy link
Contributor

Kovah commented Apr 13, 2018

Please please please sign up for the issue tracker and assign all issues you are working on to you and please ask before implementing larger features like this.

I already made some planning for this and I'm afraid to say that this might be not the correct implementation for this feature as I don't see any changes in the email sending form and the email templates does not look that good either.

@daniel89fg
Copy link
Contributor Author

Please please please sign up for the issue tracker and assign all issues you are working on to you and please ask before implementing larger features like this.

How do I do this?

I already made some planning for this and I'm afraid to say that this might be not the correct implementation for this feature as I don't see any changes in the email sending form and the email templates does not look that good either.

From the general settings you can edit colors and texts of the email template. And the already designed emails are integrated into the template in the white box.

email

@Kovah
Copy link
Contributor

Kovah commented Apr 13, 2018

How do I do this?

Sign up for the issue tracker at development.invoiceplane.com and I will add you to the developers group.

From the general settings you can edit colors and texts of the email template. And the already designed emails are integrated into the template in the white box.

That's not what the email feature should be. Email templates should replace the whole message entirely. No WYSIWYG editor or HTML in the email message, no settings to set your colors or similar stuff. The user should do everything within the HTML template like with the PDF files. The user may specify an additional message that is displayed in the email but the main content (client, invoice or user data) is processed and displayed in the template file itself.

This is the reason why contributors should ask before they work on stuff like, I wrote in the contribution guide. I appreciate your work but the feature you worked on here is not what we wanted to implement.

@daniel89fg
Copy link
Contributor Author

OK no problem. I'm already registered at development.invoiceplane.com

@Kovah Kovah changed the title (IP-512) Email templates [IP-512] Implement template files for emails Jun 28, 2018
@Kovah
Copy link
Contributor

Kovah commented Jun 28, 2018

PR will most likely be closed in favor of the correct implementation, with some of the changes from this PR being adapted.
Keep it open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants