Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP-531] Return to the application current language #658

Merged
merged 1 commit into from Oct 3, 2018

Conversation

miquel-cabanas
Copy link
Contributor

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix

  • Improvement of an existing Feature

  • New Feature

    New Feature

When translating a string not available in the current application language, (1) save the current language setting before switching to the default system-language to translate the string, and (2) once the string has been translated, restore the application to its original language setting.

I have tested the fix without errors in a multilingual setup, with 3 different non-English languages for the system, user and client:

  • all strings have been properly translated in the first language which included them according to the hierarchy: user language, system language and English; and
  • quote and invoice pdf files have been created in the client-language.

When translating a string not available in the current application
language, (1) save the current language setting before switching
to the default system-language to translate the string, and (2)
once the string has been translated, restore the application to
its original language setting.
@Kovah Kovah merged commit 9a48ff7 into InvoicePlane:v1.5.10 Oct 3, 2018
@miquel-cabanas miquel-cabanas deleted the v1.5.10-ip-531 branch October 3, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants