This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
Make it compatible with Rails form builder #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__hidden container. This is to make it compatible with Rails form, as the Rails form will append a hidden input field when render f.checkbox input
Make the rendered form compatible with Rails form builder, when Rails render a checkbox: <label id='remember-me'> <%= f.check_box :remember_me %> <%= Spree.t(:remember_me) %> </label> it will put a hidden input before the checkbox, like <label id='remember-me'> <input name="spree_user[remember_me]" type="hidden" value="0" /> <input id="spree_user_remember_me" name="spree_user[remember_me]" type="checkbox" value="1" /> Remember me </label> So if the user didn't check the checkbox, it will send the hidden '0' to the server. The order of the hidden and checkbox inputs must be preserved. If we call $input.appendTo($container); $label.appendTo($container); The hidden input will be after the checkbox, then when the server receives the params, the value will always be 0. So remove the line $input.appendTo($container); to preserve the order of these two inputs.
|
Should be ok in 2.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the rendered form compatible with Rails form builder, when Rails render a checkbox:
it will put a hidden input before the checkbox, like
So if the user didn't check the checkbox, it will send the hidden '0' to the server. The order of the hidden and checkbox inputs
must be preserved. If we call
The hidden input will be after the checkbox, then when the server receives the params, the value will always be 0. So remove the line
to preserve the order of these two inputs.