Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.1.4 now says that ionRangeSlider is not a function in Aurelia #374

Closed
cdaniel77 opened this issue May 6, 2016 · 6 comments
Closed
Assignees
Labels
[bug] low priority Bug or not a bug? Discussion Discussing the topic
Milestone

Comments

@cdaniel77
Copy link

The slider was working perfectly in 2.1.3 but since I upgraded. I cannot get the slider to work with Aurelia. I keep getting that the $(...).ionRangeSlider is not a function error.

import 'ion-rangeslider';

export class MyClass{
    $('#dateRangeSlider').ionRangeSlider();
}
@IonDen
Copy link
Owner

IonDen commented May 6, 2016

Maybe you forgot to import jquery here?

@IonDen IonDen added the Discussion Discussing the topic label May 6, 2016
@IonDen IonDen self-assigned this May 6, 2016
@cdaniel77
Copy link
Author

jQuery is installed or it wouldn't have worked with 2.1.3.

@IonDen
Copy link
Owner

IonDen commented May 9, 2016

Please check this commit: https://github.com/IonDen/ion.rangeSlider/pull/369/files
if think it brakes your code. What do you think about it?

@Robert-W
Copy link

Robert-W commented May 9, 2016

Hi I can confirm the same issue, I was on 2.1.2 and everything worked. I am also getting multipleDefine errors in our application which is using the Esri JavaScript API (built on Dojo so it uses Dojo's AMD loader). I can confirm we load jQuery as a script before we load the Esri API with dojo's loader.

I definitely agree that the commit you linked has something to do with it. I can fix the multipleDefine error by aliasing jquery in my dojoConfig like so:

var dojoConfig = {
  parseOnLoad: false,
  async: true,
  packages: [
    ....
  ],
  aliases: [
    ['jquery', 'vendor/jquery/dist/jquery.min.js'],
    ....
  ],
  deps: ['dojo/domReady!'],
  callback: function () {require(['js/main']);}
};

However that does not fix the TypeError: $(...).ionRangeSlider is not a function error

@IonDen
Copy link
Owner

IonDen commented May 9, 2016

Ok, i will investigate this more.

@IonDen IonDen added the [bug] low priority Bug or not a bug? label Jul 7, 2016
@IonDen IonDen added this to the 2.1.5 milestone Jul 7, 2016
@IonDen
Copy link
Owner

IonDen commented Dec 12, 2016

Should be fixed in 2.1.5

@IonDen IonDen closed this as completed Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[bug] low priority Bug or not a bug? Discussion Discussing the topic
Projects
None yet
Development

No branches or pull requests

3 participants