Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply toolbar top and bottom spacing using padding? #292

Closed
sn3p opened this issue Jan 28, 2021 · 2 comments · Fixed by #293
Closed

Apply toolbar top and bottom spacing using padding? #292

sn3p opened this issue Jan 28, 2021 · 2 comments · Fixed by #293

Comments

@sn3p
Copy link

sn3p commented Jan 28, 2021

Questions(s)

Is there any particular reason the top and bottom spacing inside the toolbar is done using :before and :after?

.editor-toolbar:after,
.editor-toolbar:before {
display: block;
content: ' ';
height: 1px;
}
.editor-toolbar:before {
margin-bottom: 8px
}
.editor-toolbar:after {
margin-top: 8px
}

And why the left and right spacing is added using padding?

Proposal

Would it make sense to just set the spacing using padding, and remove the :before and :after "hack"?

padding: 9px 10px;

This would make it easier to customize.
Can make a PR but pitching this first :)

@sn3p sn3p added the Question label Jan 28, 2021
@Ionaru
Copy link
Owner

Ionaru commented Jan 28, 2021

I'm not sure why this is done. The commit that introduced it is from waaaaaaaay before I made this fork: de7f1a8.
Feel free to make a PR for it :)

@sn3p
Copy link
Author

sn3p commented Jan 28, 2021

@Ionaru PR is ready #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants