Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Responsive Font Sizes #452

Merged
merged 1 commit into from
May 22, 2022
Merged

Use Responsive Font Sizes #452

merged 1 commit into from
May 22, 2022

Conversation

vanillajonathan
Copy link
Contributor

Change headers to use Responsive Font Sizes (RFS) from Bootstrap.

@Ionaru
Copy link
Owner

Ionaru commented May 21, 2022

Why is this needed? The editor already scales its text and icons with font sizes.

@vanillajonathan
Copy link
Contributor Author

The Bootstrap documentation has more information:

The mechanism automatically calculates the appropriate values based on the dimensions of the browser viewport.

https://getbootstrap.com/docs/5.2/getting-started/rfs/

The headers are defined to have the same font-size as Bootstrap which makes it play nice with websites using Bootstrap.

@Ionaru
Copy link
Owner

Ionaru commented May 22, 2022

Can you explain what is different with RFS vs without it? How it affects the editor in different conditions and the benefits of it?

(Screenshots help)

@vanillajonathan
Copy link
Contributor Author

The advantages listed in the README for RFS is:

  • No need to rescale paddings or margins anymore.
  • Text won't be chopped off in smaller viewports when RFS is applied to font sizes.
  • RFS will prevent the font size from rescaling too small, so readability can be assured.
  • The font sizes of all text elements will always remain in relation with each other.

https://github.com/twbs/rfs

The README also includes a animated GIF.

But my personal motivation is just to have the header sizes be consistent with Bootstrap since that is what I use.

@Ionaru
Copy link
Owner

Ionaru commented May 22, 2022

How does it affect the editor? What noticeable differences will there be in the context of the editor for users before and after the change?

@vanillajonathan
Copy link
Contributor Author

It doesn't affect the editor, the sizes of the headers will be slightly different, but users are not likely to notice.

Before (now):
headers-before

After:
headers-after

@Ionaru Ionaru merged commit e4610b3 into Ionaru:master May 22, 2022
@vanillajonathan vanillajonathan deleted the patch-4 branch May 22, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants