Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for text buttons #461

Merged
merged 7 commits into from
May 22, 2022
Merged

Add support for text buttons #461

merged 7 commits into from
May 22, 2022

Conversation

vanillajonathan
Copy link
Contributor

This adds support for text in buttons and in dropdown menu.

@Ionaru
Copy link
Owner

Ionaru commented May 21, 2022

I don't see why anyone would want this, none of the styling works with text...

image

@vanillajonathan
Copy link
Contributor Author

With this CSS tweak it looks better.

Copy link
Owner

@Ionaru Ionaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs some work.

Maybe some extra padding around text so they look like the icon buttons.
image

I personally think bold text look better but this might depend on the icon set someone is using. Maybe you can wrap the text in an element so it can be styled by developers. Standard bold text font-weight: bold looks pretty good with the default icons in my opinion.
image

Longer names with separate works don't work well in dropdown menus.
image

Longer names with long words make the dropdown display horizontally.
image

Copy link
Owner

@Ionaru Ionaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty <i> element is created when a button is used with just text.

image


I think there should be some spacing left and right of the text. When combined with an icon (like you show in the README) does not look good.

image


What about this?

I personally think bold text look better but this might depend on the icon set someone is using. Maybe you can wrap the text in an element so it can be styled by developers. Standard bold text font-weight: bold looks pretty good with the default icons in my opinion.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants