please upgrade parse-url to 3.x.x version

[frankLife]

git@gitlab.xxx.com:9radio/dmax.git doesn't work correctly with parse-url of 1.x.x version

[frankLife]

@IonicaBizau

[frankLife]

It seems upgrade can't fix this question . It also has a : colon in full_name field

[IonicaBizau]

Can you add examples?

[frankLife]

{ protocols: [],
  protocol: 'ssh',
  port: 9,
  resource: 'gitlab.xxx.com',
  user: 'git',
  pathname: '/dmax.git',
  hash: '',
  search: '',
  href: 'git@gitlab.xxx.com:9radio/dmax.git',
  token: '',
  toString: [Function],
  source: 'xxx.com',
  git_suffix: true,
  name: 'dmax',
  owner: 'git',
  ref: '',
  filepathtype: '',
  filepath: '',
  organization: 'git',
  full_name: 'git/dmax' }

by

const GitUrlParse = require("git-url-parse");
console.log(GitUrlParse('git@gitlab.xxx.com:9radio/dmax.git'))

with git-url-parse@10.1.0

It looks that full_name and owner are wrong

[frankLife]

@IonicaBizau please fix this, our system deeply depends on this great module.

[frankLife]

When I upgrade the git-url-parse after this issue was closed, I get the result:

{ protocols: [ 'http' ],
  protocol: 'ssh',
  port: null,
  resource: 'xxx',
  user: 'git',
  pathname: '/:9radio/dmax.git',
  hash: '',
  search: '',
  href: 'http://git@xxx/:9radio/dmax.git',
  query: {},
  token: '',
  toString: [Function],
  source: 'xxx',
  git_suffix: true,
  name: 'dmax',
  owner: ':9radio',
  commit: undefined,
  ref: '',
  filepathtype: '',
  filepath: '',
  organization: ':9radio',
  full_name: ':9radio/dmax' }

It looks the colon : in full_name and owner field are wrong

@IonicaBizau

[AMDvsTMD]

don't update when update it is wrong

[AMDvsTMD]

When I upgrade the git-url-parse after this issue was closed, I get the result:

{ protocols: [ 'http' ],
  protocol: 'ssh',
  port: null,
  resource: 'xxx',
  user: 'git',
  pathname: '/:9radio/dmax.git',
  hash: '',
  search: '',
  href: 'http://git@xxx/:9radio/dmax.git',
  query: {},
  token: '',
  toString: [Function],
  source: 'xxx',
  git_suffix: true,
  name: 'dmax',
  owner: ':9radio',
  commit: undefined,
  ref: '',
  filepathtype: '',
  filepath: '',
  organization: ':9radio',
  full_name: ':9radio/dmax' }

It looks the colon : in full_name and owner field are wrong

@IonicaBizau

you should test right then push otherwise will affect others

[IonicaBizau]

@AMDvsTMD Indeed! But in this case, the tests were wrong and failing silently 🙈 Should be fine now! 🚀