Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you help update packages to fix the vulnerability introduced by package normalize-url ? #27

Closed
paimon0715 opened this issue Jul 6, 2021 · 3 comments

Comments

@paimon0715
Copy link

paimon0715 commented Jul 6, 2021

Hi @IonicaBizau ,there is a high severity vulnerability introduced by package normalize-url

Issue

1 vulnerability (high severity) is introduced in git-up:
Vulnerability CVE-2021-33502 (high severity) is detected in package normalize-url (versions: <4.5.1,>=5.0.0 <5.3.1,>=6.0.0 <6.0.1): https://snyk.io/vuln/SNYK-JS-NORMALIZEURL-1296539

The above vulnerable package is referenced by git-up via:
git-up@4.0.2 ➔ parse-url@5.0.6 ➔ normalize-url@4.5.0

Solution

Since git-up@4.0.* is transitively referenced by 2845 downstream projects (e.g., git-url-parse 11.4.4 (latest version), lerna 4.0.0 (latest version), @lerna/version 4.0.0 (latest version), @lerna/publish 4.0.0 (latest version), @lerna/github-client 4.0.0 (latest version))

If git-up@4.0.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Could you help update packages in this version?

Fixing suggestions

In git-up@4.0.*, you can kindly perform the following upgrades (not crossing their major versions):
parse-url ^5.0.0 ➔ 5.0.3;

Note:
parse-url 5.0.3 directly depends on normalize-url@6.1.0(a vulnerability CVE-2021-33502 patched version)

Thanks for your contributions to downstream users !

Best regards,
Paimon

@paimon0715
Copy link
Author

A large number of active downstream users transitively use the lower version of git-up(@4.0.* ) (introduced vulnerablity) via unmaintained packages (cannot update their dependencies). If git-up@4.0.* can fix the issue, the vulnerable patches can be automatically propagated into the active downstream projects.

@IonicaBizau
Copy link
Owner

@paimon0715 It is a little bit tricky how to solve this. Because if we introduce a patch for the vulnerability, that means that the module won't work on Safari too... However I think it is better to fix the vulnerability.

@IonicaBizau
Copy link
Owner

🚀 Published git-up@4.0.4 depending on parse-url@6.0.0 (which is not vulnerable, but will not work on Safari)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants